Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with nrfx uarte hw async configuration validation #24313

Open
pabigot opened this issue Apr 13, 2020 · 2 comments
Open

issues with nrfx uarte hw async configuration validation #24313

pabigot opened this issue Apr 13, 2020 · 2 comments
Assignees
Labels
area: UART Universal Asynchronous Receiver-Transmitter Enhancement Changes/Updates/Additions to existing features platform: nRF Nordic nRFx priority: low Low impact/importance bug

Comments

@pabigot
Copy link
Collaborator

pabigot commented Apr 13, 2020

When using nordic,nrf-uarte the following configuration:

CONFIG_UART_ASYNC_API=y
CONFIG_UART_0_NRF_HW_ASYNC=y

ends up referencing CONFIG_UART_0_NRF_HW_ASYNC_TIMER which by default is empty, so

CONFIG_UART_##idx##_NRF_HW_ASYNC_TIMER),)) \
produces a cascading build error starting with:

/mnt/nordic/zp/modules/hal/nordic/nrfx/drivers/include/nrfx_timer.h:62:39:
  error: 'NRF_TIMER' undeclared here (not in a function); did you mean 'NRF_TIMER2'?
   62 |     .p_reg            = NRFX_CONCAT_2(NRF_TIMER, id),             \
      |                                       ^~~~~~~~~

It would also be nice if the documentation made it more clear that (a) UARTE can hold received data for an unbounded time without signalling RX_RDY if NRF_HW_ASYNC isn't enabled, and (b) (resolved by #24209) enabling NRF_HW_ASYNC requires that an associated timer be identified.

Tooling to allow the user to identify a candidate timer without having to guess which ones are in use would also be welcome.

@pabigot pabigot added bug The issue is a bug, or the PR is fixing a bug Enhancement Changes/Updates/Additions to existing features area: UART Universal Asynchronous Receiver-Transmitter platform: nRF Nordic nRFx labels Apr 13, 2020
@pabigot
Copy link
Collaborator Author

pabigot commented Apr 13, 2020

This behavior occurs only when there is no hardware flow control. nope, not true. Occurs both with and without RTS/CTS.

@carlescufi carlescufi added the priority: medium Medium impact/importance bug label Apr 21, 2020
@pabigot
Copy link
Collaborator Author

pabigot commented May 11, 2020

The bug part of this appears to be resolved by #24209 so I'm dropping that, leaving this as an enhancement to provide better diagnostics when CONFIG_UART_0_NRF_HW_ASYNC=y is provided without a companion RTC assignment like CONFIG_UART_0_NRF_HW_ASYNC_TIMER=4.

@pabigot pabigot added priority: low Low impact/importance bug and removed bug The issue is a bug, or the PR is fixing a bug priority: medium Medium impact/importance bug labels May 11, 2020
@pabigot pabigot changed the title issues with nrfx uarte hw async validation and behavior issues with nrfx uarte hw async configuration validation May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UART Universal Asynchronous Receiver-Transmitter Enhancement Changes/Updates/Additions to existing features platform: nRF Nordic nRFx priority: low Low impact/importance bug
Projects
None yet
Development

No branches or pull requests

4 participants