Latest Zephyr HEAD results in a crash in mcuboot tree

[rgundi]

The latest changes to zephyr around the flash_map has broken mcubootloader (at least for intel_s1000_crb). Below are some of the commits where it has been changed.

69c15f0
04bf2e1
6199e97

It builds fine but there's a run-time error in the function "flash_area_get_sectors".

[rgundi]

These changes were done by Findlay Feng. I couldn't find him to tag him here. @galak , can you please tag him if you know him?

[nvlsianpu]

rgundi - pleas elaborate more on the flash_area_get_sectors bug.

[nvlsianpu]

@rgundi ^^

[rgundi]

I haven't debugged it a great deal. When the latest mcubootloader tree is built with latest Zephyr and run, it results in an exception. I could figure out the exception is happening somewhere inside the function flash_area_layout which is called from flash_area_get_sectors. I believe it might be happening right after the call to flash_page_foreach function.

[rgundi]

Could figure out what the issue is. I am able to get mcuboot booting properly by modifying subsys/storage/flash_map/flash_map_default.c. I changed DT_FLASH_AREA_##i##_DEV to DT_JEDEC_SPI_NOR_0_LABEL and it is working for intel_s1000.

DT_FLASH_AREA_##i##_DEV is actually referring to SPI_0 but it should instead refer to MX25UM512 which is the SPI flash chip in intel_s1000. I think either scripts/dts/extract/flash.py or the DTS for intel_s1000 needs to be modified to achieve this.

@galak can you please pitch in?

[nashif]

@galak comments on above?

[SebastianBoe]

Me and @hakonfam have independently been affected by / reproduced this.

MCUBoot does not boot apps with the latest Zephyr.

Reproduced with nrf52840_pca10056.