lib: posix: fix out-of-bound write

parasjain2000 · MaureenHelm · commit bf1e0198a78b · 2018-06-09T08:26:18.000-05:00
Ensure that write is in buffer limits

Coverity-CID: 186491

Signed-off-by: Paras Jain &lt;parasjain2000@gmail.com&gt;
diff --git a/lib/posix/fs.c b/lib/posix/fs.c
@@ -293,7 +293,7 @@ struct dirent *readdir(DIR *dirp)
 	}
 
 	rc = strlen(fdirent.name);
-	rc = (rc <= PATH_MAX) ? rc : PATH_MAX;
+	rc = (rc < PATH_MAX) ? rc : (PATH_MAX - 1);
 	memcpy(pdirent.d_name, fdirent.name, rc);
 
 	/* Make sure the name is NULL terminated */

Original file line number	Diff line number	Diff line change
`@@ -293,7 +293,7 @@ struct dirent readdir(DIR dirp)`
`293`	`293`	`}`
`294`	`294`
`295`	`295`	`rc = strlen(fdirent.name);`
`296`		`- rc = (rc <= PATH_MAX) ? rc : PATH_MAX;`
	`296`	`+ rc = (rc < PATH_MAX) ? rc : (PATH_MAX - 1);`
`297`	`297`	`memcpy(pdirent.d_name, fdirent.name, rc);`
`298`	`298`
`299`	`299`	`/* Make sure the name is NULL terminated */`