Skip to content

Commit 0aedf8d

Browse files
ulfalizernashif
authored andcommitted
drivers: console: Kconfig: Remove redundant 'default n' properties
Bool symbols implicitly default to 'n'. A 'default n' can make sense e.g. in a Kconfig.defconfig file, if you want to override a 'default y' on the base definition of the symbol. It isn't used like that on any of these symbols though. Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
1 parent 6f29dac commit 0aedf8d

File tree

3 files changed

+0
-18
lines changed

3 files changed

+0
-18
lines changed

drivers/console/Kconfig

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ config CONSOLE_INPUT_MAX_LINE_LEN
2222

2323
config CONSOLE_HAS_DRIVER
2424
bool
25-
default n
2625
help
2726
This is an option to be enabled by console drivers to signal
2827
that some kind of console exists.
@@ -32,15 +31,13 @@ config CONSOLE_HANDLER
3231
prompt "Enable console input handler"
3332
depends on UART_CONSOLE
3433
select UART_INTERRUPT_DRIVEN
35-
default n
3634
help
3735
This option enables console input handler allowing to write simple
3836
interaction between serial console and the OS.
3937

4038
config UART_CONSOLE
4139
bool
4240
prompt "Use UART for console"
43-
default n
4441
depends on SERIAL && SERIAL_HAS_DRIVER
4542
select CONSOLE_HAS_DRIVER
4643
help
@@ -70,7 +67,6 @@ config UART_CONSOLE_INIT_PRIORITY
7067
config UART_CONSOLE_DEBUG_SERVER_HOOKS
7168
bool
7269
prompt "Debug server hooks in debug console"
73-
default n
7470
depends on UART_CONSOLE
7571
help
7672
This option allows a debug server agent such as GDB to take over the
@@ -82,7 +78,6 @@ config UART_CONSOLE_DEBUG_SERVER_HOOKS
8278
config UART_CONSOLE_MCUMGR
8379
bool
8480
prompt "Enable UART console mcumgr passthrough"
85-
default n
8681
depends on UART_CONSOLE
8782
help
8883
Enables the UART console to receive mcumgr frames for image upgrade
@@ -96,7 +91,6 @@ config USB_UART_CONSOLE
9691
depends on SERIAL
9792
select CONSOLE_HAS_DRIVER
9893
select USB_CDC_ACM
99-
default n
10094
help
10195
Enable this option to use the USB UART for console output. The output
10296
can be viewed from the USB host via /dev/ttyACM* port. Note that console
@@ -107,7 +101,6 @@ config USB_UART_CONSOLE
107101
config USB_UART_DTR_WAIT
108102
bool
109103
prompt "Wait on DTR control signal"
110-
default n
111104
depends on USB_UART_CONSOLE
112105
help
113106
Enable this option to use flow control on the console. The uart console
@@ -118,7 +111,6 @@ config RAM_CONSOLE
118111
bool
119112
prompt "Use RAM console"
120113
select CONSOLE_HAS_DRIVER
121-
default n
122114
help
123115
Emit console messages to a RAM buffer "ram_console" which can
124116
be examined at runtime with a debugger. Useful in board bring-up
@@ -137,7 +129,6 @@ config RTT_CONSOLE
137129
prompt "Use RTT console"
138130
depends on HAS_SEGGER_RTT
139131
select CONSOLE_HAS_DRIVER
140-
default n
141132
help
142133
Emit console messages to a RAM buffer that is then read by the
143134
Segger J-Link software and displayed on a computer in real-time.
@@ -176,15 +167,13 @@ config IPM_CONSOLE_SENDER
176167
bool
177168
prompt "Inter-processor Mailbox console sender"
178169
select CONSOLE_HAS_DRIVER
179-
default n
180170
help
181171
Enable the sending side of IPM console
182172

183173
config IPM_CONSOLE_RECEIVER
184174
bool
185175
prompt "Inter-processor Mailbox console receiver"
186176
select RING_BUFFER
187-
default n
188177
help
189178
Enable the receiving side of IPM console
190179

@@ -212,7 +201,6 @@ config UART_PIPE
212201
bool
213202
prompt "Enable pipe UART driver"
214203
select UART_INTERRUPT_DRIVEN
215-
default n
216204
help
217205
Enable pipe UART driver. This driver allows application to communicate
218206
over UART with custom defined protocol. Driver doesn't inspect received
@@ -233,7 +221,6 @@ config UART_MCUMGR
233221
bool
234222
prompt "Enable mcumgr UART driver"
235223
select UART_INTERRUPT_DRIVEN
236-
default n
237224
help
238225
Enable the mcumgr UART driver. This driver allows the application to
239226
communicate over UART using the mcumgr protocol for image upgrade and

drivers/console/Kconfig.telnet

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
menuconfig TELNET_CONSOLE
1010
bool "Enable a super basic telnet console service"
11-
default n
1211
select NETWORKING
1312
select NET_TCP
1413
help
@@ -68,7 +67,6 @@ config TELNET_CONSOLE_SEND_THRESHOLD
6867

6968
config TELNET_CONSOLE_SUPPORT_COMMAND
7069
bool "Add support for telnet commands (IAC) [Experimental]"
71-
default n
7270
help
7371
Current support is so limited it's not interesting to enable it.
7472
However, if proven to be needed at some point, it will be possible
@@ -108,7 +106,6 @@ config SYS_LOG_TELNET_CONSOLE_LEVEL
108106
config TELNET_CONSOLE_DEBUG_DEEP
109107
bool "Forward output to original console handler"
110108
depends on UART_CONSOLE
111-
default n
112109
help
113110
For telnet developers only, this will forward each output to
114111
original console handler. So if by chance telnet seems silent,

drivers/console/Kconfig.ws

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
menuconfig WEBSOCKET_CONSOLE
1010
bool "Enable websocket console service"
11-
default n
1211
select NETWORKING
1312
select NET_TCP
1413
select HTTP_PARSER
@@ -95,7 +94,6 @@ config SYS_LOG_WEBSOCKET_CONSOLE_LEVEL
9594
config WEBSOCKET_CONSOLE_DEBUG_DEEP
9695
bool "Forward output to original console handler"
9796
depends on UART_CONSOLE
98-
default n
9997
help
10098
For WS console developers only, this will forward each output to
10199
original console handler. So if by chance WS console seems silent,

0 commit comments

Comments
 (0)