Skip to content

Conversation

@ymc9
Copy link
Member

@ymc9 ymc9 commented Oct 29, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 29, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • packages/schema/package.json is excluded by !**/*.json
  • packages/sdk/package.json is excluded by !**/*.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !**/*.yaml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Re-enabled two previously disabled test suites by removing TODO comments and ESLint directives, and downgraded Prisma package versions from 6.18.x to 6.17.x in an integration test fixture.

Changes

Cohort / File(s) Summary
Test Suite Re-enablement
packages/schema/tests/generator/expression-writer.test.ts, packages/schema/tests/schema/validation/datasource-validation.test.ts
Removed TODO comments and ESLint jest/no-disabled-tests directives; replaced describe.skip with describe to re-activate disabled test suites
Prisma Dependency Downgrade
tests/integration/tests/cli/plugins.test.ts
Downgraded @prisma/client and prisma package versions from 6.18.x to 6.17.x in dependency specifications

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Straightforward re-enablement of test suites with removal of skip directives
  • Simple version number changes in test fixture dependencies

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ❓ Inconclusive The PR has no description provided by the author. Without any description content to evaluate, it cannot be conclusively determined whether a description exists that relates to the changeset. While the pass criteria is lenient, requiring only some relation to the changeset, an empty description provides no information to assess against this criterion. A resolution would be to add a brief description explaining the rationale for downgrading Prisma and re-enabling the tests. Consider adding a pull request description that explains the purpose of the Prisma version downgrade and why the previously skipped tests are being re-enabled. Even a brief explanation would clarify the PR's intent and help reviewers understand the context of these changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "chore: use prisma 6.17 in tests" directly addresses the main change in the changeset—downgrading Prisma dependencies from version 6.18.x to 6.17.x in the CLI plugins integration tests. While the changeset also includes re-enabling two test suites, these changes appear related to resolving issues with the Prisma version. The title is clear, concise, and accurately reflects the key modification without misleading or off-topic language.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 124fb29 and 0aae54c.

⛔ Files ignored due to path filters (9)
  • packages/plugins/trpc/tests/projects/nuxt-trpc-v10/package.json is excluded by !**/*.json
  • packages/plugins/trpc/tests/projects/nuxt-trpc-v11/package.json is excluded by !**/*.json
  • packages/plugins/trpc/tests/projects/t3-trpc-v11/package.json is excluded by !**/*.json
  • packages/runtime/package.json is excluded by !**/*.json
  • packages/schema/package.json is excluded by !**/*.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !**/*.yaml
  • tests/integration/test-run/package.json is excluded by !**/*.json
  • tests/integration/tests/frameworks/nextjs/test-project/package.json is excluded by !**/*.json
  • tests/integration/tests/frameworks/trpc/test-project/package.json is excluded by !**/*.json
📒 Files selected for processing (3)
  • packages/schema/tests/generator/expression-writer.test.ts (0 hunks)
  • packages/schema/tests/schema/validation/datasource-validation.test.ts (1 hunks)
  • tests/integration/tests/cli/plugins.test.ts (2 hunks)
💤 Files with no reviewable changes (1)
  • packages/schema/tests/generator/expression-writer.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: build-test (20.x)
  • GitHub Check: dependency-review
  • GitHub Check: build-test (20.x)
  • GitHub Check: build-test (20.x)
  • GitHub Check: OSSAR-Scan
🔇 Additional comments (1)
tests/integration/tests/cli/plugins.test.ts (1)

78-78: Prisma 6.17.x is available and stable; confirm downgrade rationale.

Verification shows:

  • Prisma 6.17.0 and 6.17.1 are available as stable releases on npm
  • Prisma 6.18.x has no reported critical issues in public sources

Please confirm the reason for downgrading from 6.18.x and ensure it aligns with your project requirements.

@ymc9 ymc9 merged commit c2d318c into dev Oct 29, 2025
12 checks passed
@ymc9 ymc9 deleted the chore/prisma-17-test branch October 29, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants