Skip to content

Conversation

@mhodgson
Copy link
Contributor

For prisma-client generator there are some delegate_aux_* properties that, if not removed, cause type errors with the models since those fields have been removed from the model types.

Previous discussion here: #2177 (comment)

cc/ @ymc9

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 25, 2025

📝 Walkthrough

Walkthrough

A new private method, transformVariableStatementProps, is added to the EnhancerGenerator class to remove delegate_aux_* fields from variable statements in the prismaNamespace.ts file during the processClientTypesNewPrismaGenerator step. The method modifies relevant source code nodes and ensures the file is updated accordingly.

Changes

File(s) Change Summary
packages/schema/src/plugins/enhancer/enhance/index.ts Added transformVariableStatementProps method; updated processClientTypesNewPrismaGenerator to remove delegate_aux_* fields; imported invariant helper.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1d3026 and 4a5abbc.

📒 Files selected for processing (1)
  • packages/schema/src/plugins/enhancer/enhance/index.ts (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: dependency-review
  • GitHub Check: build-test (20.x)
  • GitHub Check: OSSAR-Scan
  • GitHub Check: build-test (20.x)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: build-test (20.x)
🔇 Additional comments (4)
packages/schema/src/plugins/enhancer/enhance/index.ts (4)

2-2: LGTM: Import addition is appropriate.

The invariant import is correctly added and will be used in the new transformVariableStatementProps method for runtime type assertions.


572-597: LGTM: Processing logic for prismaNamespace.ts is well-implemented.

The implementation correctly:

  • Handles file parsing and syntax validation with appropriate error handling
  • Uses a safe file transformation pattern (temp file + rename)
  • Follows the established code structure used elsewhere in the method
  • Properly integrates with the new transformVariableStatementProps method

The approach aligns well with the PR objective to restore processing of the prismaNamespace.ts file.


756-775: LGTM: New transformation method is well-implemented.

The transformVariableStatementProps method correctly:

  • Follows the established pattern of similar transformation methods in the class
  • Uses appropriate type safety with invariant for runtime assertions
  • Properly handles the removal of auxiliary fields from variable initializers
  • Maintains consistency with existing helper method usage (findAuxProps, removeFromSource)

The implementation effectively addresses the core issue of removing delegate_aux_* properties from variable initializers.


1094-1098: LGTM: Helper method follows established patterns.

The findAuxProps method is correctly implemented:

  • Mirrors the structure of the existing findAuxDecls method
  • Uses appropriate SyntaxKind for property assignments (needed for variable initializers)
  • Maintains consistent naming and filtering logic with the delegate auxiliary relation prefix

This helper method complements the existing code structure well.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@ymc9 ymc9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mhodgson . I still couldn't figure out what triggers generation of such content in prismaNamespace.ts, but the change LGTM. I'm merging it and will publish a patch release.

@ymc9 ymc9 merged commit 5fafb0d into zenstackhq:dev Jul 27, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants