-
-
Couldn't load subscription status.
- Fork 126
chore: release 2.17.1 for Prisma 6.12 #2198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThis change updates version numbers for the JetBrains IDE package and the Prisma dependencies used in test scaffolding and CLI plugin integration tests. The JetBrains IDE package version is incremented from 2.17.0 to 2.17.1, and the Prisma-related dependencies are updated from 6.11.x to 6.12.x. Changes
Estimated code review effort1 (less than 30 minutes) Possibly related PRs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
tests/integration/tests/cli/plugins.test.ts (1)
88-88: Same observation as above for the dev dependencySee previous comment—using a shared
PRISMA_VERSIONconstant (or even re-using the version frompackage.jsonif available) will reduce maintenance overhead and the risk of mismatched versions.
🧹 Nitpick comments (2)
script/test-scaffold.ts (1)
22-22: Consider pinning the exact Prisma patch version for deterministic test runsUsing a floating patch range (
6.12.x) may unexpectedly pull in a newer patch that changes behaviour or introduces regressions, breaking your scaffolded tests without any code change on your side.-run('npm i --no-audit --no-fund typescript prisma@6.12.x @prisma/client@6.12.x zod@^3.22.4 decimal.js @types/node'); +const PRISMA_VERSION = '6.12.1'; // keep in one place for easy future bumps +run(`npm i --no-audit --no-fund typescript prisma@${PRISMA_VERSION} @prisma/client@${PRISMA_VERSION} zod@^3.22.4 decimal.js @types/node`);Even if you prefer the wildcard, extracting the version into a variable avoids duplication and makes the next bump simpler.
tests/integration/tests/cli/plugins.test.ts (1)
78-78: Duplicate hard-coded Prisma version
@prisma/client@6.12.xis hard-coded here but appears again below forprisma@6.12.x. Extracting a constant (e.g.,const PRISMA_VERSION = '6.12.x';) would keep the two in sync and simplify the next bump.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (20)
package.jsonis excluded by!**/*.jsonpackages/ide/jetbrains/package.jsonis excluded by!**/*.jsonpackages/language/package.jsonis excluded by!**/*.jsonpackages/misc/redwood/package.jsonis excluded by!**/*.jsonpackages/plugins/openapi/package.jsonis excluded by!**/*.jsonpackages/plugins/swr/package.jsonis excluded by!**/*.jsonpackages/plugins/tanstack-query/package.jsonis excluded by!**/*.jsonpackages/plugins/trpc/package.jsonis excluded by!**/*.jsonpackages/plugins/trpc/tests/projects/nuxt-trpc-v10/package.jsonis excluded by!**/*.jsonpackages/plugins/trpc/tests/projects/nuxt-trpc-v11/package.jsonis excluded by!**/*.jsonpackages/plugins/trpc/tests/projects/t3-trpc-v11/package.jsonis excluded by!**/*.jsonpackages/runtime/package.jsonis excluded by!**/*.jsonpackages/schema/package.jsonis excluded by!**/*.jsonpackages/sdk/package.jsonis excluded by!**/*.jsonpackages/server/package.jsonis excluded by!**/*.jsonpackages/testtools/package.jsonis excluded by!**/*.jsonpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml,!**/*.yamltests/integration/test-run/package.jsonis excluded by!**/*.jsontests/integration/tests/frameworks/nextjs/test-project/package.jsonis excluded by!**/*.jsontests/integration/tests/frameworks/trpc/test-project/package.jsonis excluded by!**/*.json
📒 Files selected for processing (3)
packages/ide/jetbrains/build.gradle.kts(1 hunks)script/test-scaffold.ts(1 hunks)tests/integration/tests/cli/plugins.test.ts(2 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
script/test-scaffold.ts (1)
packages/testtools/src/schema.ts (1)
run(45-67)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: OSSAR-Scan
- GitHub Check: build-test (20.x)
- GitHub Check: build-test (20.x)
- GitHub Check: dependency-review
- GitHub Check: build-test (20.x)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (1)
packages/ide/jetbrains/build.gradle.kts (1)
12-12: Version bump looks goodThe standalone version update is consistent with the release objective and doesn’t introduce any build-script side effects.
No description provided.