merge dev to main (v2.7.2)

[ymc9]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request includes updates to several files across the project. The build.gradle.kts file for the JetBrains plugin is updated to version 2.7.2. The datamodel-validator.ts file sees enhancements to validation logic, including improved error messages and simplified checks for relationships. The datamodel-validation.test.ts file adds new test cases and refines existing ones to improve coverage and clarity in error handling. Lastly, the index.ts file modifies the makePrismaIdFilter method to decode the resourceId parameter, ensuring proper handling of URL-encoded characters.

Changes

File	Change Summary
packages/ide/jetbrains/build.gradle.kts	Updated version from 2.7.1 to 2.7.2.
packages/schema/src/language-server/validator/datamodel-validator.ts	Removed getLiteral import; added conditional check in parseRelation method; simplified isSelfRelation method; adjusted validation logic in validateRelationField.
packages/schema/tests/schema/validation/datamodel-validation.test.ts	Added new test cases; refined error messages; enhanced relation handling tests; improved coverage for existing tests.
packages/server/src/api/rest/index.ts	Modified makePrismaIdFilter method to decode resourceId before processing.

Possibly related PRs

• merge dev to main (v2.1.0) #1438: Updates the version in build.gradle.kts from 2.0.3 to 2.1.0.
• chore: bump version #1459: Updates the version in build.gradle.kts from 2.1.1 to 2.1.2.
• chore: bump version #1481: Updates the version in build.gradle.kts from 2.1.2 to 2.2.0.
• chore: bump version #1729: Updates the version in build.gradle.kts from 2.5.2 to 2.6.0.
• merge dev to main (v2.6.2) #1752: Updates the version in build.gradle.kts from 2.6.1 to 2.6.2.
• Configurable REST API id divider #1785: Introduces a configurable ID divider in the REST API.
• chore: bump version #1788: Updates the version in build.gradle.kts from 2.7.0 to 2.7.1.
• merge dev to main (v2.7.1) #1789: Updates the version in build.gradle.kts from 2.7.0 to 2.7.1.
• chore: bump version #1792: Updates the version in build.gradle.kts from 2.7.1 to 2.7.2.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

packages/schema/src/language-server/validator/datamodel-validator.ts (1)

301-304: Clarify the error message for missing relation attributes

The error message in the accept call could be more precise to help developers understand the requirement. Consider rephrasing it for clarity.

Suggested change:

- 'Field for one side of relation must carry @relation attribute with both "fields" and "references"'
+ 'One side of the relation must define a @relation attribute with both "fields" and "references" specified'

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 5db1a2c and f1afc15.

⛔ Files ignored due to path filters (13)

• package.json is excluded by !**/*.json
• packages/ide/jetbrains/package.json is excluded by !**/*.json
• packages/language/package.json is excluded by !**/*.json
• packages/misc/redwood/package.json is excluded by !**/*.json
• packages/plugins/openapi/package.json is excluded by !**/*.json
• packages/plugins/swr/package.json is excluded by !**/*.json
• packages/plugins/tanstack-query/package.json is excluded by !**/*.json
• packages/plugins/trpc/package.json is excluded by !**/*.json
• packages/runtime/package.json is excluded by !**/*.json
• packages/schema/package.json is excluded by !**/*.json
• packages/sdk/package.json is excluded by !**/*.json
• packages/server/package.json is excluded by !**/*.json
• packages/testtools/package.json is excluded by !**/*.json

📒 Files selected for processing (4)

• packages/ide/jetbrains/build.gradle.kts (1 hunks)
• packages/schema/src/language-server/validator/datamodel-validator.ts (4 hunks)
• packages/schema/tests/schema/validation/datamodel-validation.test.ts (2 hunks)
• packages/server/src/api/rest/index.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• packages/ide/jetbrains/build.gradle.kts

🧰 Additional context used

🔇 Additional comments (5)

packages/server/src/api/rest/index.ts (1)

1234-1243: Improved handling of URL-encoded characters in resource IDs.

The changes to makePrismaIdFilter method now properly decode the resourceId using decodeURIComponent. This enhancement ensures correct handling of special characters in both single and compound IDs, aligning with best practices for URL parameter processing.

packages/schema/src/language-server/validator/datamodel-validator.ts (2)

10-10: Import necessary utilities from '@zenstackhq/sdk'

The added import statement correctly brings in the required functions for data model validation.

---

200-201: Simplify isSelfRelation method for clarity

The isSelfRelation method has been simplified to check if the field's type reference matches its containing model. This enhances readability and maintains correct logic for identifying self-relations.

packages/schema/tests/schema/validation/datamodel-validation.test.ts (2)

454-454: Test correctly checks for missing "fields" and "references".

The test case appropriately validates that an error is thrown when either "fields" or "references" is missing in a relation definition, ensuring both are provided together.

---

544-544: Test accurately verifies missing @relation attribute details.

The test effectively checks that an error is raised when a relation field lacks a @relation attribute with both "fields" and "references" specified on one side of the relation.