Breaks ruby-add-log-current-method

[dgutov]

Take this example, move point to bar:

class Test
  def foo
    bar
  end
end

(ruby-add-log-current-method) should return "Test#foo". It returns "Test" instead.

I'd be happy if (enh-ruby-add-log-current-method) returned the expected value, but that doesn't happen either.

Originally reported as dgutov/robe#47 (comment).

[zenspider]

Can you point me at some doco or something for this? Esp a contract of some sort.

What calls this function and why? I wouldn't expect a ruby-* function to work in ERM.

[dgutov]

add-log-current-defun does. robe-context does too.

I wouldn't expect a ruby-* function to work in ERM.

What about enh-ruby-add-log-current-method, then?

[dgutov]

Can you point me at some doco or something for this?

ruby-add-log-current-method has a docstring with examples.

[zenspider]

I think I just fixed this for most forms.

[dgutov]

The lack of support for class << self is unfortunate: we do use this form, for instance. Another problem is that it does not return fully qualified module names. Example:

module A
  module B
    class C
      def foo
        _
      end
    end
  end
end

(enh-ruby-add-log-current-method) returns "C#foo" instead of "A::B::C#foo".

[zenspider]

Failing tests would be more actionable...

[dgutov]

Isn't the above description unambiguous? I hope you realize I'm not using this major mode myself.

[dgutov]

But check these out: https://github.com/emacs-mirror/emacs/blob/b6a57fb80c49bcd9163966d612671a5256f3a1a8/test/lisp/progmodes/ruby-mode-tests.el#L492-L559

[zenspider]

Closing in favor of #156.