Implement container-interop

[gianarb]

This proposal is a simple implementation of ContainerInterface.
Now we can use it in zend-stratigility-skeleton for example.

[weierophinney]

My only concern is that the container-interop interfaces were just admitted as a draft PSR... which means there's still a very high liklihood of changes possible. We may want to do this as an "InteropManager" or similar, with documentation in the README indicating it's experimental and unstable until the PSR for container interop is accepted.

[gianarb]

I can try to write a InteropManager that extends Zend\ServiceManager\ServiceManager but implements Interop\Container\ContainerInterface

OR

we can write a little interop project between service manager and interop-container that implement this feature..

Tomorrow if php-fig will release psr about this stuff we can write another interop project with them proposal

[gianarb]

@weierophinney this is a project's draft :)
https://github.com/gianarb/zend-servicemanager-container-interop

easy easy

[weierophinney]

@gianarb That's exactly what I was suggesting!

Pinging @mvriel : is there a phpdoc annotation for indicating a class or method is "unstable"?

[gianarb]

In your opinion is a good idea builds a new project?

👍 It's clear in my opinion and we can not add unstable class in zend-servicemanager

[mvriel]

@weierophinney no, the best you could do is use to mark it using @access protected or @access private; though that tag is deprecated and removed from PSR-5

[sandrokeil]

Looks good. Maybe one problem could be the optional parameters. I know it's not a problem in PHP but it's not so clean. Isn't it?

[gianarb]

@sandrokeil the intereface is already implemented without modified.. Why could it be a problem?

[sandrokeil]

@gianarb I think it's confusing because the ContainerInterface function definition is get($id) and in ServiceManager we have get($name, $usePeeringServiceManagers = true). Also in ZF3 it's planned to have public function get($name, array $options = []).

The ServiceLocatorInterface is ok, that's right. But it could be changed in ZF3. So it's magic to call $sl->get('service', $options) or $sl->get('service', false).

So I think it's not real support of interoperability. But we could fix this for ZF3.

[Ocramius]

My only concern is that the container-interop interfaces were just admitted as a draft PSR...

container-interop as-is is a project on its own. It will maybe become a PSR, yes /cc @moufmouf

@gianarb I think it's confusing because the ContainerInterface function definition is get($id) and in ServiceManager we have get($name, $usePeeringServiceManagers = true).

Note that this is perfectly legit PHP

[weierophinney]

Based on the feedback from @Ocramius, I'm 👍 - however, it looks like we need to add a little more test coverage, @gianarb - this small change has decreased coverage. :)

[weierophinney]

Merged to develop for release with 2.6.0.

[Ocramius]

Note: this should be a constrained version (1.0.*)

[gianarb]

Sorry #5