Port view helper from Zend View #10
Conversation
There is no class name collision; this repo uses a different namespace. 😄 I've got things merged to a local branch, but have one test failure I'm trying to sort out; once that's resolved, I can merge. I'll push any changes back to your branch so that folks can review what made it into the final patch. |
- CS fixes per phpcs, including whitespace additions and wrapping long lines. - Use PHPUnit 5+ namespaces. - Use getMockBuilder + getMock.
weierophinney
force-pushed
the
feature/viewhelper
branch
from
8b68438 to
710a294
Compare
|
Interestingly, the test failures are dependent on dependency versions. All PHP 5.6 versions, and all "lowest" targets pass, while locked/latest in all PHP 7 versions fail. I'm attempting to isolate the problem now. |
|
It's PHPUnit. Evidently, it's persisting changes to superglobals between calls in versions 6 and 7. |
Tests were failing on PHPUnit 6 and 7, due to a change in how those versions persist superglobals, and, specifically, $_SESSION. This patch resets the value of $_SESSION between tests, which solves the problems observed.
|
Thanks, @alextech! |
As requested in #3
Many thanks to @adamlundrigan for comprehensive checklist of tasks.
Build will most likely fail until Zend View 3 is released to satisfy new composer restrictions that prevent class name collisions.
May need feedback on naming convention of PluginFlashMessenger vs. ViewHelperFlashMessenger in import statements.
Notable changes in port are: