Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Remove deprecated class map generator documentation #19

Merged
merged 3 commits into from
Nov 8, 2019
Merged

Remove deprecated class map generator documentation #19

merged 3 commits into from
Nov 8, 2019

Conversation

arueckauer
Copy link

This PR removes the documentation of the ZF 2 script bin/classmap_generator.php, which never was part of this component.

Instead the usage of Composer for autoloading is suggested and a reference to the migration guide added.

@froschdesign
Copy link
Member

froschdesign commented Nov 7, 2019

@weierophinney @michalbundyra
Is the Zend\Loader\ClassMapAutoloader class deprecated or can this class be marked as deprecated?

@weierophinney
Copy link
Member

Honestly, this entire package can likely be deprecated.

The only places it is used anywhere within ZF are:

  • zend-modulemanager (which uses the ModuleAutoloader as a fallback to the application autoloader)
  • zend-http (which uses the PluginClassLoader for loading HTTP header implementations, and should likely move to a standard plugin manager, but instead is going to be eventually deprecated in favor of Diactoros anyways)

In short: I don't know that we need to deprecate anything; it's more likely that we'll abandon it after the move to Laminas, in favor of inlining those facilities into the packages that use them currently.

@froschdesign
Copy link
Member

@weierophinney

zend-modulemanager (which uses the ModuleAutoloader as a fallback to the application autoloader)

And there is already a pull request to drop zend-loader: zendframework/zend-modulemanager#78 😃

…it's more likely that we'll abandon it after the move to Laminas…

Okay, that's the information we need here. Thanks!

Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two minor changes are needed.

(We refuse all other adjustments here, like missing array example for ClassMapAutoloader or a separate migration section.)

@michalbundyra
Copy link
Member

Thanks, @arueckauer!

michalbundyra added a commit that referenced this pull request Nov 8, 2019
…map-generator

Remove deprecated class map generator documentation
michalbundyra added a commit that referenced this pull request Nov 8, 2019
@michalbundyra michalbundyra merged commit 030b6db into zendframework:master Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants