This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Improvement: tests #195
Merged
Improvement: tests #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant bootstrap file (we can use composer autoload) - Optimize getting static files (__DIR__ notation). - Rename protected method in tests to avoid `_` prefix, changed also to private. - Optimize if statements and getting values from env vars - Add PHPDoc with property type
froschdesign
approved these changes
Oct 15, 2019
|
All of it is in preparation to run "online" tests. I have done it on my branch already, but want to push changes part by part, instead everything in one PR. @froschdesign Thanks for your reviews. Appreciate a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant bootstrap file (we can use composer autoload)
Optimize getting static files (
__DIR__notation).Rename protected method in tests to avoid
_prefix,changed also to private.
Optimize if statements and getting values from env vars
Add PHPDoc with property type
Is this related to quality assurance?