This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Multiple headers of the same type #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froschdesign
approved these changes
Oct 15, 2019
Fixes behaviour of toString when added multiple headers of the same type using addHeaderLine method. The behavious was correct when we adding headers using header instance (via method addHeader). In all cases behaviour of toString should be the same.
michalbundyra
added a commit
that referenced
this pull request
Nov 29, 2019
Multiple headers of the same type
michalbundyra
added a commit
that referenced
this pull request
Nov 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes behaviour of toString when added multiple headers of the same type
using
addHeaderLinemethod. The behavious was correct when we addingheaders using header instance (via method
addHeader).In all cases behaviour of toString should be the same.
masterbranch, and submit against that branch.CHANGELOG.mdentry for the fix.