Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Updates reason phrase for 425 response status code #313

Merged

Conversation

weierophinney
Copy link
Member

The IANA HTTP status codes list was updated on 2018-07-02 to reflect a new IETF draft, draft-ietf-httpbis-replay-04, which details a header that may be used to indicate that an "early data" request may not yet be accepted, as no TLS handshake has been previously made, and that the request myust be retried after receiving the 425 response.

Without this change, tests fail on all platforms as the hard-coded reason phrase in Zend\Diactoros\Response references an early, non-standards-track usage of the status code.

The IANA HTTP status codes list was updated on 2018-07-02 to reflect a
new IETF draft, draft-ietf-httpbis-replay-04, which details a header
that may be used to indicate that an "early data" request may not yet be
accepted, as no TLS handshake has been previously made, and that the
request myust be retried after receiving the 425 response.
@weierophinney weierophinney merged commit 4527c29 into zendframework:master Jul 9, 2018
weierophinney added a commit that referenced this pull request Jul 9, 2018
weierophinney added a commit that referenced this pull request Jul 9, 2018
@weierophinney weierophinney deleted the hotfix/iana-425-change branch July 9, 2018 19:43
@samsonasik
Copy link
Contributor

@weierophinney should zend-http Response class be updated as well ? https://github.com/zendframework/zend-http/blob/master/src/Response.php#L143

@weierophinney
Copy link
Member Author

@samsonasik Yes, please!

@samsonasik
Copy link
Contributor

@weierophinney I've created PR zendframework/zend-http#153 for it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants