This repository has been archived by the owner on Jan 29, 2020. It is now read-only.
explicitly display mysqli error #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froschdesign
reviewed
Oct 3, 2017
| @@ -206,7 +206,8 @@ public function prepare($sql = null) | |||
| $this->resource = $this->mysqli->prepare($sql); | |||
| if (!$this->resource instanceof \mysqli_stmt) { | |||
| throw new Exception\InvalidQueryException( | |||
| 'Statement couldn\'t be produced with sql: ' . $sql, | |||
| ' Error #' . $this->mysqli->errno . ': ' . $this->mysqli->error . | |||
There was a problem hiding this comment.
Sorry for the late update. Should be sorted now.
mwillbanks
suggested changes
Oct 20, 2017
|
@mwillbanks I'm having some trouble creating a mock connection to a database. I've pushed up my attempt in the last commit. Sorry, it's a bit messy. I tried following the Pdo test setup as an example. Could you give me some suggestions on how to create an appropriate mock or stub for the db connection? |
|
This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
|
|
This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#64. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to show mysqli errno and error explicitly. Without this, mysqli errors do not get shown in some debuggers when preparing sql statements, for example whoops.
Here is an example with whoops before
and after the change.
I think some components already use this style, for example zend-http/src/Client/Adapter/Socket.php line 278.