fix(combobox): cache management for option values and labels #698
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lack of memoized variable coordination presented a corner-case bug for consumers where value-label affinity could be lost. For example:
Detail
The updated code moves previously memoized option
labels
,selectedValues
,disabledValues
, andhiddenValues
into an object cache along withvalues
. By removing the coordination, these values can be collectively reinitialized (and memoized) every time the combobox options change.