Skip to content

fix(dropdowns.next): Combobox with isBare option never shows horiz scrollbar to preserve styling #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ze-flo merged 2 commits into from
Aug 1, 2024
Merged

fix(dropdowns.next): Combobox with isBare option never shows horiz scrollbar to preserve styling #1872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
079a187
fix(dropdowns): `<Combobox isBare>` always hides input’s horiz scroll…
ze-flo Jul 24, 2024
97ac681
fix: preserve overflow-y: auto when isMultiselectable
ze-flo Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/dropdowns.next/src/elements/combobox/Combobox.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,10 +194,14 @@ describe('Combobox', () => {
});

it('renders `isBare` styling as expected', () => {
const { getByTestId } = render(<TestCombobox isBare />);
const { getByTestId, rerender } = render(<TestCombobox isBare />);
const combobox = getByTestId('combobox');

expect(combobox.firstChild).toHaveStyleRule('border', 'none');
expect(combobox.firstChild).toHaveStyleRule('overflow-y', 'visible');

rerender(<TestCombobox isBare isMultiselectable />);
expect(combobox.firstChild).toHaveStyleRule('overflow-y', 'auto');
});

it('renders `isCompact` styling as expected', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/dropdowns.next/src/views/combobox/StyledTrigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export const StyledTrigger = styled.div.attrs({
'data-garden-id': COMPONENT_ID,
'data-garden-version': PACKAGE_VERSION
})<IStyledTriggerProps>`
overflow-y: auto;
overflow-y: ${props => (props.isBare && !props.isMultiselectable ? 'visible' : 'auto')};
/* prettier-ignore */
transition:
border-color 0.25s ease-in-out,
Expand Down