chore: code review getStatusColor

Author: geotrev

packages/avatars/src/styled/utility.ts

@@ -20,19 +20,25 @@ export interface IStyledStatusIndicatorProps extends ThemeProps<DefaultTheme> {
   readonly $type?: IAvatarProps['status'] | 'active';
 }
 
+const StatusColorParams = {
+  active: { hue: 'crimson', light: { shade: 700 }, dark: { shade: 600 } },
+  available: { hue: 'mint', light: { shade: 500 }, dark: { shade: 400 } },
+  away: { hue: 'orange', light: { shade: 500 }, dark: { shade: 400 } },
+  transfers: { hue: 'azure', light: { shade: 500 }, dark: { shade: 400 } },
+  offline: { hue: 'grey', light: { shade: 500 }, dark: { shade: 400 } }
+};
+
 export function getStatusColor(
   theme: IStyledStatusIndicatorProps['theme'],
   type?: IStyledStatusIndicatorProps['$type']
 ): string {
-  return (
-    {
-      active: getColor({ hue: 'crimson', light: { shade: 700 }, dark: { shade: 600 }, theme }),
-      available: getColor({ hue: 'mint', light: { shade: 500 }, dark: { shade: 400 }, theme }),
-      away: getColor({ hue: 'orange', light: { shade: 500 }, dark: { shade: 400 }, theme }),
-      transfers: getColor({ hue: 'azure', light: { shade: 500 }, dark: { shade: 400 }, theme }),
-      offline: getColor({ hue: 'grey', light: { shade: 500 }, dark: { shade: 400 }, theme })
-    }[type as string] || 'transparent'
-  );
+  if (type === undefined) {
+    return 'transparent';
+  }
+
+  const colorArgs = StatusColorParams[type];
+
+  return getColor({ ...colorArgs, theme });
 }
 
 export function getStatusBorderOffset(props: IStyledStatusIndicatorProps): string {