-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Building Markers #704
Add Building Markers #704
Conversation
As I mentioned on Discord, I don't really see a use case for enabling markers for individual buildings. I think it makes more sense to have a global setting for it. |
Do the markers update (position) if the building is moved by Zeus? |
Not currently. That would definitely be needed for the setting, but wasn't in the workflow I had in mind. (Now it does!) |
The code for this feature is spread out over 3 components. Let's consolidate all of this functionality in a new component for better maintainability - maybe |
Having an issue where placement preview is making the marker spawn at [-1000, -1000], and then CuratorObjectEdited is not being triggered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is mostly good and a nice useful feature. Just needs some cleanup.
I did some minor cleanup and fixes. Building markers were being created for all objects when the placement preview was enabled. Also, changed the marker size calculation to take the difference between the two bounding box extremes. @ampersand38 Please look my changes over and merge when ready. |
When merged this pull request will: