Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Configurable scroll buffer #936

Merged
merged 4 commits into from
Jan 4, 2022
Merged

Feature: Configurable scroll buffer #936

merged 4 commits into from
Jan 4, 2022

Conversation

kunalmohan
Copy link
Member

resolve #240

@kunalmohan kunalmohan marked this pull request as ready for review December 15, 2021 11:16
a-kenji
a-kenji approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@a-kenji a-kenji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it works well, I tried a few different buffer sizes.

The only thing is that you can't specify large numbers like that.

zellij-utils/assets/config/default.yaml Outdated Show resolved Hide resolved
@kunalmohan kunalmohan merged commit e23d06b into main Jan 4, 2022
@kunalmohan kunalmohan deleted the configure-scroll-buffer branch January 4, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-kenji a-kenji a-kenji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Limit the scrollback buffer by default, make it configurable.
2 participants
@kunalmohan @a-kenji