Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for osc 8 escape code #822

Merged
merged 6 commits into from
Nov 22, 2021

Conversation

tlinford
Copy link
Contributor

This adds support for osc8, for a quick idea of how it works see: https://iterm2.com/documentation-escape-codes.html, while this gist has a lot more details covered.

The case of a newline immediately after a link ends, for example

printf '\e]8;;\n\nhttp/example.com\e\\LINK1\e]8;;\e\\\n

was a bit problematic, since the line gets padded with empty characters up to the width of the row:

screenshot-2021-10-31T17:23:28

I handled this by adding a zero width null character to end the link in this situation, not quite sure if that's a reasonable solution though.

@imsnif
Copy link
Member

imsnif commented Nov 22, 2021

Hey @tlinford - what's the status of this?

@tlinford
Copy link
Contributor Author

Hey, I think it's pretty much good to go, want me to go ahead and merge?

@imsnif
Copy link
Member

imsnif commented Nov 22, 2021

Sure, if you think it's good then go for it.

@tlinford tlinford merged commit a96b9d8 into zellij-org:main Nov 22, 2021
@tlinford tlinford deleted the feature/osc8-support branch November 22, 2021 17:54
@a-kenji a-kenji mentioned this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants