-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color theme config #550
Conversation
This is not quite ready yet, since the theme reverts to its default I am not sure where we should attach the client I would be happy about any input here. |
Just a heads up: some terminals don't support truecolor. That's the reason our default theme uses 256 colors. It might be a good idea to differentiate the themes to 256 and truecolor themes. Or at least provide a configuration option for 256 colored themes. |
Oh yeah, that is also possible to specify currently. |
The idea was to have screen and plugins to store a copy of the palette and generate the mode_info themselves when the mode changes (instead of having the router thread do that). Original comment: https://discord.com/channels/771367133715628073/773128553524494367/843837258120298577 But it'll, probably, be a while before this is done (Brooks is currently working on the resizing algorithm), so maybe go with plan B and store the palette in What do you think @imsnif ? |
I think that is a good idea for now then. |
* add option `theme` that allows for setting of a theme, the default is `default` * under `themes` the themes can be described as follows: either: ``` themes: default: fg: [0,0,0] bg: [0,0,0] black: [0,0,0] red: [0,0,0] green: [0,0,0] yellow: [0,0,0] blue: [0,0,0] magenta: [0,0,0] cyan: [0,0,0] white: [0,0,0] orange: [0,0,0] ``` or ``` themes: default: fg: 0 bg: 0 black: 0 red: 0 green: 0 yellow: 0 blue: 0 magenta: 0 cyan: 0 white: 0 orange: 0 ``` If the key is different from default, it needs to either be specified on start with `options --theme [THEME]`, or in the configuration file under theme: [THEME]. closes zellij-org#390
add option
theme
that allows for setting of a theme,the default is
default
under
themes
the themes can be described as follows:either
or
If the key is different from default, it needs to either be specified on
start with
options --theme [THEME]
, or in the configuration file undertheme: [THEME].
closes #390