Adding field active_at and using it to sort panes #294
Conversation
|
Just wanted to confirm this. Should I change those failing tests to match the new behavior? |
|
@dantepippi Yeah, we'll probably be fine changing tests, but it would be good if we also had a couple of other people test it out so we can be sure the behavior is "correct" before setting it in stone with snapshots. You'll probably need |
|
Hey! Thanks! The behavior seems correct to me. |
|
This is a cool solution and I like the behaviour. :) |
Thank you! I'm going to need some directions on how to adapt the snapshots to modify the tests. |
Using last activity time to determine which pane was previously active when moving back to a direction. Changing active_at type to Instant
Previous behavior was to go to the largest overlap. Now it should go to the most recently used pane. Used cargo insta review to update the snapshots.
dantepippi
force-pushed
the
focus_previous_pane_issue_230
branch
from
bab5279
to
4f7ad31
Compare
|
@dantepippi Stellar work! Nicely done tackling the testing system too, that's no easy beast to tame 😅 Consider it merged! |
Using last activity time to determine which pane was previously active when moving back to a direction.
Closes #230