fix(layouts): naming and gototabname #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshheyse
pushed a commit
to joshheyse/zellij
that referenced
this pull request
Mar 11, 2023
* fix(layouts): properly apply tab name * fix(gototabname): do not crash and properly apply default shell * style(fmt): rustfmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes three bugs:
GoToTabNameaction would crash when creating a tab, this was fixed by removing theself.is_pending = falsestatement in the various layout applying method and only leaving it in the main one (not really sure why they were there in the first place...)GoToTabNamenow uses the default shell when creating new tabs (with the--createflag)Thanks @har7an for finding the first issue!