Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(panes): moving and toggling embed/float with frames #1909

Merged
merged 2 commits into from
Nov 5, 2022
Merged

fix(panes): moving and toggling embed/float with frames #1909

merged 2 commits into from
Nov 5, 2022

Conversation

imsnif
Copy link
Member

@imsnif imsnif commented Nov 5, 2022

This fixes two bugs:

  1. When moving panes with ctrl + h + , sometimes their content would spill onto the boundaries (thanks @hola-soy-milk for the heads up!)
  2. When embedding a floated pane or vice-verca, we'd sometimes erase part or all of the frame. Thanks to @xJonathanLEI for the heads up!)

@imsnif imsnif temporarily deployed to cachix November 5, 2022 13:25 Inactive
@imsnif imsnif merged commit 6c3c0f5 into main Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@imsnif