Log thread_bus IPC messages only in debug mode
#1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that tells us whether zellij was started with the `--debug` CLI flag.
mode, and discard the message otherwise.
per logfile, totaling 32 MiB of logs at most (in two files).
thread and make sure the value of the `--debug` CLI flag is propagated to the server, too. This means that to enable debug mode, the server must be started with the `--debug` flag. This happens when the first client that starts the zellij session has the `--debug` flag set, because it will be forwarded to the server. Subsequent clients attaching to the same session with the `--debug` flag specified **do not** override the value of the `DEBUG` variable. Hence, if the server wasn't started in debug mode, this cannot be changed.
har7an
added a commit
that referenced
this pull request
Oct 17, 2022
for logging of IPC messages in `thread_bus` only when the `--debug` flag is specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new static global variable
DEBUG_MODE, accessible viazellij_utils::consts. It is set when the server is spawned and depends on whether the server was started with the--debugflag. This is automatically the case when the first client starting a session is started with the--debugflag.The variable is stored globally to make it easily accessible from within error-handling functions without having to carry the option everywhere. Since it is set by the server upon creation, it is only set exactly once: When the session is started for the first time. Hence, clients connecting to a session with the
--debugflag cannot override theDEBUG_MODEvalue.Logging of the Instructions sent in the
zellij_server::thread_buswill only happen when the server is running inDEBUG_MODE. Otherwise, the error message is still shown as before, but the Instruction isn't included.This is done in an attempt to reduce flooding the terminal and logs for long instructions. Also increases the logsize to 16 MiB per file to keep it from filling up very quickly when a large instruction is dumped there.