Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix osc params 1024 bytes limit #1711

Merged
merged 2 commits into from
Sep 3, 2022

Conversation

tlinford
Copy link
Contributor

@tlinford tlinford commented Sep 3, 2022

turn off default-features for vte, since default includes no_std, and in that case the osc params buffer is capped at 1024 bytes.

Fixes #1709

* vte's default includes no_std, and in that case the osc params buffer is capped at 1024 bytes
@tlinford tlinford temporarily deployed to cachix September 3, 2022 12:19 Inactive
@tlinford
Copy link
Contributor Author

tlinford commented Sep 3, 2022

@imsnif you ok with updating to vte 0.11.0?
the only diff is a bugfix, and increased rust version requirement.

@imsnif
Copy link
Member

imsnif commented Sep 3, 2022 via email

@tlinford
Copy link
Contributor Author

tlinford commented Sep 3, 2022

Hey, I'm afk so can't check, but are you sure this is the fix for the bug? I was debugging this a little yesterday, tried this upgrade and it didn't work. I seemed to reach the base64 decoding as a possible direction. Could be that I was super tired and missed something though. If this fixes it for you, go for it.

On Sat, Sep 3, 2022, 2:20 PM Thomas Linford @.> wrote: @imsnif https://github.com/imsnif you ok with updating to vte 0.11.0? the only diff is a bugfix, and increased rust version requirement. — Reply to this email directly, view it on GitHub <#1711 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGCHTRQ7BRA6CAHXZN25WDV4M7CRANCNFSM6AAAAAAQD4CWGI . You are receiving this because you were mentioned.Message ID: @.>

The version update fixes a different bug (Fixed infinite loop in Params iterator when 32nd parameter is a subparameter), the fix is the default-features=false :)

@tlinford tlinford temporarily deployed to cachix September 3, 2022 15:20 Inactive
@tlinford tlinford merged commit a58a5ca into zellij-org:main Sep 3, 2022
@tlinford tlinford deleted the fix/osc52-payload-cut branch September 3, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSC 52 events doesn't be forward when the contents is more than or equal to 1024 bytes
2 participants