fix(router): retry messages when server is not ready #1651
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash introduced in the latest release where Zellij would sometimes crash on startup with this error:
This was a race condition that happened when the Zellij client sent a message to the server before it was ready. This was exposed in the latest release because we broke down the queries we make to the terminal emulator (for stuff like pixel-to-cell dimensions and the terminal color palette) into several different messages. This caused them to be sent faster and hit the issue.
This fix involves adding a retry queue for these kinds of messages, placing instructions there when the server is not ready, and retrying them again along with the next messages when they come.
Right now I only implemented this for this one particular message that was causing the issue as an experiment. Care should be taken before duplicating this logic to other instructions.