Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log every panic to the logfile #1602

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Log every panic to the logfile #1602

merged 4 commits into from
Jul 26, 2022

Conversation

raphCode
Copy link
Contributor

@raphCode raphCode commented Jul 25, 2022

As an extension to logging only panics in the client (#1433 (comment)), this change should log every panic, no matter if it happens in client or server.

I believe I had some sessions disappearing mysteriously without being attached, so I never saw panic traces. This should be the first step to investigate.

Example log entry:

ERROR  |zellij_utils::errors     | 2022-07-25 15:57:30.802 [main      ] [zellij-utils/src/errors.rs:94]: Panic occured:
thread: main
location: At /home/<redacted>/zellij/zellij-utils/src/ipc.rs:158:68
message: called `Result::unwrap()` on an `Err` value: Io(Os { code: 32, kind: BrokenPipe, message: "Broken pipe" })

@raphCode raphCode temporarily deployed to cachix July 25, 2022 14:05 Inactive
@raphCode raphCode temporarily deployed to cachix July 25, 2022 14:05 Inactive
@raphCode raphCode temporarily deployed to cachix July 25, 2022 14:05 Inactive
@raphCode raphCode temporarily deployed to cachix July 26, 2022 15:29 Inactive
@raphCode raphCode temporarily deployed to cachix July 26, 2022 15:29 Inactive
@raphCode raphCode temporarily deployed to cachix July 26, 2022 15:29 Inactive
@raphCode raphCode temporarily deployed to cachix July 26, 2022 15:47 Inactive
@raphCode raphCode temporarily deployed to cachix July 26, 2022 15:47 Inactive
@raphCode raphCode temporarily deployed to cachix July 26, 2022 15:47 Inactive
@raphCode raphCode merged commit 408f520 into main Jul 26, 2022
@har7an har7an deleted the log_everything branch October 23, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant