Merge --layout and --layout-path #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @SpyrosRoum - cool that you're picking this up! Please reach out if you have any questions or concerns. |
|
Thank you @imsnif, basic implementation is done without issues, I just need to update the e2e test as soon as I find time (hopefully today)! |
imsnif
approved these changes
May 28, 2022
| // We look in the default dir | ||
| LayoutFromYamlIntermediate::from_dir(layout, layout_dir.as_ref()) | ||
| } | ||
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1412
A layout is considered local if:
layout.extension().is_some() || layout.components().count() > 1This check produces the following results:
"foo": Abs
"foo.yml": Local
"./foo": Local
"foo/bar": Local
"foo/bar.yml": Local
TODO:
EDIT by @imsnif
For quick reference, after this change:
--layout striderloads the strider.yaml layout from the configured layouts folder (by default config/layouts)--layout ./relative/path.yamlor--layout /absolute/path.yamlwill load the layout file