feat: Attach sessions by unique prefix name (#1169) #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This make attaching to sessions more convenient since only the first character(s) of the session name must be typed. If this prefix matches multiple sessions and is therefore ambiguous, zellij will complain and show all sessions names starting with these characters. If any session name matches the given string exact, it is attached immediately, therefore it is always possible to attach to every session, even if the set of session names is not prefix-free.
raphCode
force-pushed
the
attach_convenience
branch
from
4bffef9
to
3173c06
Compare
This gets rid of a match block which just exits on errors anyway.
|
wtf, a 2 character string message change made the e2e test pass again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This missing feature bothered me for a while, see also #1169.
Maybe I also just wanted to have some fun with Rust's fantastic
matchblocks :DIdeas what could be improved:
session_exists()by using my newmatch_session_name()at callsites (no idea if this gives a benefit)Commit message body:
This make attaching to sessions more convenient since only the first character(s) of the
session name must be typed.
If this prefix matches multiple sessions and is therefore ambiguous, zellij will complain
and show all sessions names starting with these characters.
If any session name matches the given string exact, it is attached immediately, therefore
it is always possible to attach to every session, even if the set of session names is not
prefix-free.