Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(copy): add copy_on_select option #1298

Merged
merged 7 commits into from
Apr 16, 2022
Merged

Conversation

tlinford
Copy link
Contributor

@tlinford tlinford commented Apr 5, 2022

Add copy_on_select option:

  • With default value of true, keep current behavior of automatically
    copying selection to clipboard when done selecting.
  • when false, on mouse release the selection remains, and
    can be copied with the Copy action.

Resolve #1192

with default value of true, keep current behavior of automatically
copying selection to clipboard when done selecting.
with copy_on_select = false, on mouse release the selection remains, and
can be copied with the `Copy` action.
@tlinford tlinford temporarily deployed to cachix April 5, 2022 08:54 Inactive
@tlinford tlinford temporarily deployed to cachix April 5, 2022 08:54 Inactive
@tlinford tlinford temporarily deployed to cachix April 7, 2022 19:18 Inactive
@tlinford tlinford temporarily deployed to cachix April 7, 2022 19:18 Inactive
@tlinford
Copy link
Contributor Author

tlinford commented Apr 8, 2022

@a-kenji is there anything that should be added in default.yaml for the Copy action?
I don't think we should enable it by default but wondering if it should maybe be there commented?

@a-kenji
Copy link
Contributor

a-kenji commented Apr 8, 2022

@tlinford,
Maybe we can add it as a comment.
But it should definitely be added to the documentation.

@tlinford tlinford temporarily deployed to cachix April 14, 2022 18:36 Inactive
@tlinford tlinford temporarily deployed to cachix April 14, 2022 18:36 Inactive
@tlinford tlinford marked this pull request as ready for review April 14, 2022 19:17
@tlinford tlinford temporarily deployed to cachix April 14, 2022 19:24 Inactive
@tlinford tlinford temporarily deployed to cachix April 14, 2022 19:24 Inactive
@tlinford tlinford merged commit 198625b into main Apr 16, 2022
@tlinford tlinford deleted the feature/config-copy-on-select branch April 16, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to disable copy on selection and change the color of selection?
2 participants