Fix crash in intermediate no-tabs state #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #929
There are various cases in which we try to move clients between tabs and there are no tabs to move them to (eg. when closing the last tab under certain race conditions). This makes the move function resilient, recovering when possible (eg. moving clients to another tab) and logging the error when not (no tabs left).
This also adds a fix to the tab bar to handle situations in which there is no focused tab for the client in question (also related to these edge cases). What it does is not update its own state - which while not desirable, doesn't really matter because this is a corrupt state and only happens because an additional render happened before we managed to close everything.