fix(screen): handle various edge cases rather than crashing #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can we log these instances, maybe just with |
Good call, thanks. Added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1134, #805 and probably a few others
When this code was written, the Zellij architecture was a little bit different and it didn't make a whole lot of sense to perform checks to make sure the Tab a certain Action is operating on actually exists. As we moved stuff around (namely to a client/server architecture but not just), these edge-cases became more and more possible.
This fixes a lot (all?) of these potential pitfalls by performing a no-op in case the tab an action would like to use doesn't exist.