Add navigation with alt + arrow keys #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The binding of the keys can now be specified with: - Alt: 'c' - Alt: Up - Alt: Down - Alt: Left - Alt: Right
a-kenji
approved these changes
Mar 25, 2022
|
Thanks @a-kenji ! I think it wasn't working for me because I tried to make it: pub enum CharOrArrow {
Char(char),
Right,
Left,
Up,
Down,
}And gave up trying to figure what Serde wanted from me :) Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes in our STDIN parsing have broken the
Alt + []navigation method. After some investigation, we could not find a method to bring these back without causing crashes for various systems. While it is theoretically possible to get these to work again, it would require a non-trivial amount of work and likely force us to write our own STDIN parser.Because of this, in a previous PR we moved from parsing STDIN with termion to parsing it with termwiz. Termwiz supports alt + arrow key codes, which allow us to step out of this problem by providing a user friendly alternative.
This PR adds this alternative - allowing pane navigation with
Alt+<arrow keys>.The implementation is a little bit hacky in the configuration parsing front. I'm hoping @a-kenji can have a look and maybe find a better way.