Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compatibility): replace wide characters under cursor properly #1196

Merged
merged 2 commits into from
Mar 9, 2022

Conversation

imsnif
Copy link
Member

@imsnif imsnif commented Mar 9, 2022

Fixes #1117 (among other things)

The issue above had to do with wide characters overflowing a cached-render. Meaning we would be doing needless extra padding (since we weren't checking for wide characters in that specific case) and not rendering the frame above the padding (since we'd already rendered it before and thought it was unchanged). This fixes it by making the padding wide-character aware.

This fix also includes better wide-character handling when replacing characters under the cursor. Better handling cases where we replace a wide-character with a non-wide-character and vice-versa.

@imsnif imsnif temporarily deployed to cachix March 9, 2022 09:30 Inactive
@imsnif imsnif temporarily deployed to cachix March 9, 2022 09:30 Inactive
@imsnif imsnif temporarily deployed to cachix March 9, 2022 09:32 Inactive
@imsnif imsnif temporarily deployed to cachix March 9, 2022 09:32 Inactive
@imsnif imsnif merged commit 95e512c into main Mar 9, 2022
@har7an har7an deleted the fix-replace-wide-chars branch October 23, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrolling in ncmpcpp breaks the rendering
1 participant