fix: Allow terminal title passthrough even when not drawing pane frames. #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-kenji
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the terminal title is set in the pane frame render function, which does not seem to run when displaying pane borders is disabled.
This pull adds a
render_terminal_titlemethod to thePanetrait and arender_terminal_title_if_neededmethod to thePaneContentsAndUistruct. The latter can be called fromTab::renderto ensure the title is always set when needed.Note: First time looking at the Zellij codebase so I don't know if this is the correct approach. However, it does fix the issue for me with pane frames disabled (and terminal title setting still works with them enabled.)
Closes #1111
Other related issue: #883