fix(tests): ensure e2e tests use updated plugins #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- launch zellij with --data flag in e2e tests, to avoid using prebuilt plugins from assets dir, and instead use the ones from the docker mount. - make the tests use plugins built in release mode to avoid some test failures due to timing issues. - format Makefile.toml.
|
note: had to change the config for the ssh service to use UID 1001 to match the runner's UID |
|
🎉 nice, congrats :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spent some time debugging some strange test failures in #1045 with @RobWalt, and we realized that currently
the e2e tests are using the pre-built plugins from the assets folder. Also they are installed into a directory inside the container
that persists between runs when testing locally, so even updating the plugins in
assetswas not giving reliable results.Solve this issue by:
--data-dirflag in e2e tests, to avoid using prebuiltplugins from assets dir, and instead use the ones from the docker
mount.
failures due to timing issues.
Other changes are auto-formatting of Makefile.toml.