Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update arg parsing to clap v3 #1017

Merged
merged 2 commits into from
Jan 23, 2022
Merged

Update arg parsing to clap v3 #1017

merged 2 commits into from
Jan 23, 2022

Conversation

tranzystorekk
Copy link
Contributor

Updates arg parsing to the recently released clap 3 with the derive feature (the new structopt).

Let me know if these should be changed:

  • clap now colors its help output by default
  • structopt used to propagate version to subcommands by default, clap doesn't

jaeheonji
jaeheonji approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@jaeheonji jaeheonji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This upgrade is very good!
I've tested and everything is fine.

There is only one feedback for UX.
Thank you for your effort!

zellij-utils/src/setup.rs Outdated Show resolved Hide resolved
@tlinford tlinford merged commit e58b67c into zellij-org:main Jan 23, 2022
@tranzystorekk tranzystorekk deleted the clap-v3 branch January 24, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeheonji jaeheonji jaeheonji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tranzystorekk @jaeheonji @tlinford