-
-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When a pane closes on its own and is in full screen, the FULLSCREEN message remains in the tip line #748
Comments
@imsnif not sure why the tests failed in the pr, everything seems fine on my machine. |
@tlinford - the tests also passed a few times for me locally. I re-ran them in the CI now, but this is a little concerning... could be that we introduced an extra render here and there's a race condition? |
All that was added here was two calls to |
I need to go afk now so can't check, but it's worth checking if those calls add an additional |
You are right, there are some additional calls to render down the line, I think because when Don't really get what happened in the failed test run though. |
Ideally I'd like to avoid adding more renders. We might need to rethink some of the
But we don't live in an ideal world :) Do you think we can achieve this without adding extra renders somehow? |
In this case, as a workaround, I think we can skip the |
Sounds good. Will have to play with it a little to make sure there isn't some edge case the tests don't cover that is harmed by this. |
cool, I pushed the changes and the tests ran fine, and I'm seeing the expected behavior locally. |
Looks great, thanks! |
To reproduce:
The text was updated successfully, but these errors were encountered: