Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Killing client crashes server #1949

Closed
Tracked by #1568
raphCode opened this issue Nov 16, 2022 · 2 comments · Fixed by #1965
Closed
Tracked by #1568

Killing client crashes server #1949

raphCode opened this issue Nov 16, 2022 · 2 comments · Fixed by #1965

Comments

@raphCode
Copy link
Contributor

Killing an attached client brings the server down reliably. I thought we had fixed this?

repro:

  • zellij --session test
  • kill (SIGKILL) client
  • alternativly: timeout --signal KILL 1 zellij attach test
ERROR  |zellij_utils::errors::not| 2022-11-16 16:18:16.119 [server_router] [zellij-utils/src/errors.rs:452]: Panic occured:
             thread: server_router
             location: At zellij-server/src/lib.rs:279:42
             message: Program terminates: a fatal error occured

Caused by:
    0: failed to handle instruction for client 2
    1: received empty message from client
INFO   |zellij_server::wasm_vm   | 2022-11-16 16:18:16.120 [wasm      ] [zellij-server/src/wasm_vm.rs:328]: wasm main thread exits
ERROR  |zellij_utils::errors::not| 2022-11-16 16:18:16.120 [async-std/runti] [zellij-utils/src/errors.rs:452]: Panic occured:
             thread: async-std/runtime
             location: At zellij-server/src/pty.rs:776:30
             message: Program terminates: a fatal error occured

Caused by:
    0: failed to spawn terminals for layout
    1: failed to listen for bytes from PTY
    2: failed to async-send to screen
    3: failed to send message to screen
    4: Originating Thread(s)

    5: failed to send message to channel

Happens with 0.33.0 and dc92290.
I also tested this in v0.25.0, v0.26.1, v0.28.1.
Strange, I thought we fixed something like this long ago.

@imsnif
Copy link
Member

imsnif commented Nov 18, 2022

@raphCode - was this fixed by #1955 ?

@raphCode
Copy link
Contributor Author

raphCode commented Nov 18, 2022

Nope, I tried at 5ad0429:
timeout -s kill 1 zellij attach; zellij ls

Session is still killed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants