Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dim (SGR) effect can produce unexpected visuals #1802

Closed
pedromfedricci opened this issue Oct 16, 2022 · 0 comments · Fixed by #1803
Closed

Dim (SGR) effect can produce unexpected visuals #1802

pedromfedricci opened this issue Oct 16, 2022 · 0 comments · Fixed by #1803

Comments

@pedromfedricci
Copy link
Contributor

The dim (SGR) effect is only cleared when bold effect is also cleared, which can produce some unexpected visuals. Take for example a cli tool that manages it's own vertical and floating views (like a term text editor). If the dim effect is applied to text in the left sided view, right sided views' text that is at the same height is also affected, even though they are separated text views.

I've tested with both alacritty and kitty, and indeed the overextended effect only occurs when the tool is used inside a zellij term.

The attached video showcases the unexpected visual effect.

Information:
Linux
Zellij: 0.31.4
Alacritty: 0.10.1-rc1
Kitty: 0.21.2
Helix: 22.08.1

dim-effect-issue.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant