Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: the status bar should indicate that a pane is in full screen and mention how many hidden panes there are #168

Closed
imsnif opened this issue Feb 10, 2021 · 14 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@imsnif
Copy link
Member

imsnif commented Feb 10, 2021

When placing a pane in full screen (<ctrl-g> + p + f), it would be useful if this is indicated in the status bar. Also, if the status bar indicated how many panes are "hiding" behind the full screen pane.

Something like: FULLSCREEN (+ 3 hidden panes) on the right side.

To get started

  1. Add a new plugin API that would find out if the pane is in fullscreen here (at the time of this writing): https://github.com/zellij-org/zellij/blob/main/src/common/wasm_vm.rs#L35
  2. Add a new API (or combine with point 1?) that would find out how many panes there are currently on screen.
  3. Change the UI here: https://github.com/zellij-org/zellij/tree/main/default-tiles/status-bar
@imsnif imsnif added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 10, 2021
@takezyou
Copy link
Contributor

Hello, @imsnif.
I would like to start contributing the project from the simplest.
Can I start with this issue?

@a-kenji
Copy link
Contributor

a-kenji commented Apr 24, 2021

Hello, @takezyou.
We are happy to have you tackle this issue!
If you have any questions please don't hesitate to ask.

@takezyou
Copy link
Contributor

Hi, @a-kenji.
Thank you!
I have question already if that's ok.
How can I check the value of this API?

@a-kenji
Copy link
Contributor

a-kenji commented Apr 25, 2021

@takezyou
Here should be a good start:
https://github.com/zellij-org/zellij/blob/413a24b77fd78f19385522f96137e80f146f2485/src/client/tab.rs
https://github.com/zellij-org/zellij/blob/main/src/common/screen.rs

Sure, thats always ok!

@takezyou
Copy link
Contributor

takezyou commented May 5, 2021

@a-kenji
Do you know where to change to show the status bar in full screen?

@a-kenji
Copy link
Contributor

a-kenji commented May 5, 2021

@takezyou

I think this could be a good start:
https://github.com/a-kenji/zellij/blob/6e5600efc8a9ae2136128c0c4f348d45ee739203/src/common/screen.rs#L235 ,

but there needs to be a way in order to tell that the active plugin, in this case the status-bar should stay, even in fullscreen.

Maybe a good way would be to have a flag in the layout file, that marks this plugin as always there?
Or else maybe just check for the status bar and resize to lines up to the status bar.

cc @TheLostLambda maybe you have some good input here as well!

@TheLostLambda
Copy link
Member

I you can add a flag to always show a Pane in Zellij, then it should be easy for plugins to set that as a setting – much like they set their max_height at the moment :)

@takezyou
Copy link
Contributor

@TheLostLambda @a-kenji
Thank you!!

I you can add a flag to always show a Pane in Zellij, then it should be easy for plugins to set that as a setting

Should it implement something similar to set_max_height?
Is my understanding correct?

@a-kenji
Copy link
Contributor

a-kenji commented May 18, 2021

@takezyou
Yes, that is correct!

@imsnif
Copy link
Member Author

imsnif commented Sep 1, 2021

@takezyou - the status bar and tab bar are now always shown in full screen, so implementing this should be a lot easier.

@TheLostLambda
Copy link
Member

Additionally, if you are feeling brave, I'd like to add a more general "minibuffer" feature to the status bar, similar to how Emacs displays messages to the user. That way this feature, the startup tips, and the "Text has been copied" messages can all share a single system and adding new status messages in the future will be trivial.

I'm happy to chat more about the idea if you are interested!

@takezyou
Copy link
Contributor

takezyou commented Sep 4, 2021

@imsnif
Thank you.
I'll try this challenge again.

@TheLostLambda
I'm very interested in the "minibuffer" feature, but I'd like to try it after I've accomplished the current task first.

@takezyou
Copy link
Contributor

takezyou commented Sep 5, 2021

@imsnif
#450
Please review. This pull request.

@qballer qballer added the hacktoberfest For the hacktoberfest month label Sep 22, 2021
@imsnif imsnif removed the hacktoberfest For the hacktoberfest month label Sep 25, 2021
@takezyou
Copy link
Contributor

takezyou commented Oct 1, 2021

@imsnif
#450
I've been merged. Please close.

@imsnif imsnif closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants