Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clicking the left mouse button will cause neovim inside zellij to enter visual mode #1309

Closed
wertasy opened this issue Apr 10, 2022 · 5 comments · Fixed by #1329
Closed

clicking the left mouse button will cause neovim inside zellij to enter visual mode #1309

wertasy opened this issue Apr 10, 2022 · 5 comments · Fixed by #1329
Labels
compatibility Issues with VT/terminal compatibility mouse Issues related to mouse events suspected bug

Comments

@wertasy
Copy link

wertasy commented Apr 10, 2022

Basic information

zellij --version: zellij 0.27.0 (default config)
tput lines: 41
tput cols: 187
uname -av or ver(Windows):
Linux wert 4.19.112-2.el8.x86_64 #1 SMP Web Jun 10 09:04:49 EDT 2020 x86_64 x86_64 x86_64 GNU/Linux

List of programs you interact with as, PROGRAM --version: output cropped meaningful, for example:
nvim --version: NVIM v0.7.0-dev+1400-g233014f92 (used the appimage release, with set mouse=a)
xfce4-terminal --version: xfce4-terminal 0.8.8 (Xfce 4.14)

Further information

Reproduction steps:

  1. nvim --clean --cmd='set mouse=a' /tmp/zellij-45190034/zellij-log/zellij.log
  2. click any word with the left mouse button

Noticeable behavior:
clicking the left mouse button will cause neovim inside zellij to enter visual mode.
1649602074(1)

@imsnif
Copy link
Member

imsnif commented Apr 10, 2022

For me this behaves the same way as it does with vim open (with the set mouse=a setting) even without Zellij. I think this is a vim thing.

@wertasy
Copy link
Author

wertasy commented Apr 11, 2022

For me this behaves the same way as it does with vim open (with the set mouse=a setting) even without Zellij. I think this is a vim thing.

It seems that zellij converts the mouse single-click event to a double-click event, because double-clicking without zellij will make nvim enter the v mode, which is consistent with the situation of single-clicking in zellij.

@wertasy wertasy closed this as completed Apr 11, 2022
@wertasy wertasy reopened this Apr 11, 2022
@tlinford
Copy link
Contributor

as far as I can tell this changed between 0.26.1 and 0.27.0, I'm guessing the termwiz refactoring might have something to do with it.

@a-kenji a-kenji added the compatibility Issues with VT/terminal compatibility label Apr 11, 2022
@tlinford
Copy link
Contributor

Debugged this a little, and what is happening now is that mouse button press events are getting repeated as well as mouse hold events.

@tlinford tlinford added the mouse Issues related to mouse events label Apr 14, 2022
@imsnif
Copy link
Member

imsnif commented Apr 15, 2022

Debugged this a little, and what is happening now is that mouse button press events are getting repeated as well as mouse hold events.

Ah, just saw this now. Could we maybe rig the repeater to only repeat mouse hold events then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Issues with VT/terminal compatibility mouse Issues related to mouse events suspected bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants