Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hang/crash when closing last pane in tab with hidden floating pane #1241

Closed
Tracked by #1100
tlinford opened this issue Mar 19, 2022 · 2 comments · Fixed by #1266
Closed
Tracked by #1100

hang/crash when closing last pane in tab with hidden floating pane #1241

tlinford opened this issue Mar 19, 2022 · 2 comments · Fixed by #1266

Comments

@tlinford
Copy link
Contributor

zellij --version: 0.27.0

When there is a hidden floating pane, and one closes all other panes so that the current tab would close, zellij hangs, and subsequent keypresses cause a crash.

Steps to reproduce:

  1. Open floating pane
  2. Focus existing tiled pane
  3. Press ctrl+d or close pane with keybindings
  4. At this point everything is stuck, press any key and it will crash with:
Error occurred in server:

  × Thread 'screen' panicked.
  ├─▶ Originating Thread(s)
  │   	1. stdin_handler_thread: AcceptInput
  │   	2. screen_thread: WriteCharacter
  │
  ├─▶ At zellij-server/src/tab/mod.rs:822:60
  ╰─▶ called `Option::unwrap()` on a `None` value

This happens after #1239.

@imsnif
Copy link
Member

imsnif commented Mar 19, 2022

Honestly, I'm wondering what the correct behaviour here should be. We can fix the crash as before, but what'll happen is that the floating pane will be unceremoniously closed without any indication to the user. What would you expect here?

@tlinford
Copy link
Contributor Author

Good question - the previous behavior seemed mostly sensible to me, but I can see that might be surprising in some cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants