Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade 0932 #966

Merged
merged 25 commits into from
May 26, 2023
Merged

Upgrade 0932 #966

merged 25 commits into from
May 26, 2023

Conversation

vivekvpandya
Copy link
Contributor

@vivekvpandya vivekvpandya commented Feb 7, 2023

Upgrade from 0.9.29 to 0.9.32 fixes #927

Notable PR
paritytech/substrate#11649 (has migrations)
paritytech/polkadot#6091
paritytech/substrate#11981
https://github.com/paritytech/substrate/pull/12109/files

Summary of changes

  • pallet-preimage now handles preimages for pallet-democracy
  • pallet-scheduler is now able to execute code stored in preimages inside pallet-preimage
  • pallet-tokens offers extensives hooks:
            type OnDust = orml_tokens::TransferDust<Runtime, DustAccount>;
            type OnKilledTokenAccount = ();
            type OnNewTokenAccount = ();
            type OnSlash = ();
            type PostDeposit = ();
            type PostTransfer = ();
            type PreDeposit = ();
            type PreTransfer = ();
  • (try-runtime) pre_upgrade now returns a vector of bytes that can be used in post_upgrade (deprecates get/set_temp_storage)
  • Origin is now replaced by RuntimeOrigin
  • Call is now replaced by RuntimeCall

Make things compile with polkadot v0.9.32.
Please note that certain things are just commneted out and will be fixed/improved in upcoming commits.
@vivekvpandya vivekvpandya added the s:in-progress The pull requests is currently being worked on label Feb 7, 2023
@vivekvpandya vivekvpandya added this to the v0.3.9 milestone Feb 7, 2023
@vivekvpandya vivekvpandya self-assigned this Feb 7, 2023
@vivekvpandya vivekvpandya marked this pull request as ready for review February 10, 2023 10:18
@vivekvpandya vivekvpandya added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels Feb 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #966 (ac43b82) into main (033b6a3) will increase coverage by 0.04%.
The diff coverage is 93.36%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
+ Coverage   91.53%   91.57%   +0.04%     
==========================================
  Files          93       93              
  Lines       21765    21845      +80     
==========================================
+ Hits        19923    20005      +82     
+ Misses       1842     1840       -2     
Flag Coverage Δ
tests 91.57% <93.36%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
zrml/authorized/src/lib.rs 61.80% <ø> (ø)
zrml/authorized/src/mock.rs 37.50% <ø> (ø)
zrml/court/src/lib.rs 73.09% <ø> (ø)
zrml/court/src/mock.rs 33.33% <ø> (ø)
zrml/court/src/weights.rs 0.00% <0.00%> (ø)
zrml/global-disputes/src/lib.rs 56.62% <0.00%> (ø)
zrml/global-disputes/src/mock.rs 68.42% <ø> (ø)
zrml/liquidity-mining/src/lib.rs 60.84% <ø> (ø)
zrml/liquidity-mining/src/mock.rs 100.00% <ø> (ø)
zrml/liquidity-mining/src/weights.rs 0.00% <0.00%> (ø)
... and 29 more

@sea212 sea212 self-assigned this May 22, 2023
@sea212 sea212 added s:in-progress The pull requests is currently being worked on and removed s:review-needed The pull request requires reviews labels May 22, 2023
@sea212 sea212 added s:review-needed The pull request requires reviews and removed s:in-progress The pull requests is currently being worked on labels May 23, 2023
sea212
sea212 previously approved these changes May 23, 2023
Chralt98
Chralt98 previously approved these changes May 24, 2023
Copy link
Member

@Chralt98 Chralt98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just wanted to mention this #936 .

Both try-runtime migration tests checked ✅ .

Client connects to old nodes ✅ .

I get this test failure:

failures:

---- integration_tests::xcm::tests::transfers::transfer_roc_to_relay_chain stdout ----
thread 'integration_tests::xcm::tests::transfers::transfer_roc_to_relay_chain' panicked at 'assertion failed: `(left == right)`
  left: `999988806429`,
 right: `948894198216`', runtime/battery-station/src/integration_tests/xcm/tests/transfers.rs:238:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

My command was: cargo test --all-features

node/Cargo.toml Show resolved Hide resolved
runtime/common/src/lib.rs Show resolved Hide resolved
runtime/zeitgeist/Cargo.toml Show resolved Hide resolved
@sea212 sea212 dismissed stale reviews from Chralt98 and themself via 6f82f9a May 25, 2023 14:59
@sea212
Copy link
Member

sea212 commented May 25, 2023

@Chralt98

failures:

[...]

My command was: cargo test --all-features

Interesting, seems the test script didn't consider all features. Fixed in #1006.

In regards to the failing tests: XCM instruction weights have been improved, see this and this (diff here). Equally true for Polkadot.

Mismatching fees fixed in 6f82f9a

@sea212 sea212 requested a review from Chralt98 May 25, 2023 15:02
Chralt98
Chralt98 previously approved these changes May 26, 2023
@sea212 sea212 merged commit 24ab42e into main May 26, 2023
@sea212 sea212 deleted the upgrade_0932 branch May 26, 2023 09:25
@sea212 sea212 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to polkadot v0.9.32
4 participants