Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all dot files offered in open file dialog #4302

Closed
1 task done
kellyfelkins opened this issue Dec 20, 2023 · 3 comments
Closed
1 task done

Not all dot files offered in open file dialog #4302

kellyfelkins opened this issue Dec 20, 2023 · 3 comments
Labels
bug [core label] file finder Feedback for file management, navigation, etc

Comments

@kellyfelkins
Copy link

kellyfelkins commented Dec 20, 2023 •
edited by notpeter
Loading

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I'm using the jetbrains keymap.

  1. I do a cmd-shift-o to search for a project file.
  2. I type ".env". As I type the matching files are listed.

I have 2 files in my project, ".envrc" and ".envrc.template". ".envrc.template" is listed. ".envrc" is not listed.

Environment

Zed: v0.116.1 (stable)
OS: macOS 12.6.7
Memory: 16 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Screen Shot 2023-12-20 at 10 47 25 AM

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

Zed.log
2023-12-14T18:51:16 [INFO] build git repository "deps/snowflex/.git"
2023-12-14T18:51:16 [INFO] build git repository "deps/snowflex/.git"
2023-12-14T18:51:17 [INFO] build git repository "deps/snowflex/.git"
2023-12-14T18:51:17 [INFO] build git repository "deps/snowflex/.git"
2023-12-14T18:51:17 [INFO] build git repository "deps/snowflex/.git"
2023-12-14T19:03:36 [INFO] reload git repository ".git"
2023-12-14T19:03:37 [INFO] reload git repository ".git"
2023-12-14T19:05:45 [INFO] reload git repository ".git"
2023-12-14T19:05:47 [INFO] reload git repository ".git"
2023-12-14T19:05:47 [INFO] reload git repository ".git"
2023-12-14T19:06:00 [INFO] reload git repository ".git"
2023-12-14T19:06:00 [INFO] reload git repository ".git"
2023-12-14T19:06:01 [INFO] reload git repository ".git"
2023-12-14T19:06:01 [INFO] reload git repository ".git"
2023-12-14T19:07:20 [INFO] reload git repository ".git"
2023-12-14T19:07:21 [INFO] reload git repository ".git"
2023-12-14T19:07:21 [INFO] reload git repository ".git"
2023-12-14T19:07:21 [INFO] reload git repository ".git"
2023-12-14T19:07:21 [INFO] reload git repository ".git"
2023-12-14T19:07:23 [INFO] reload git repository ".git"
2023-12-14T19:07:23 [INFO] reload git repository ".git"
2023-12-14T19:07:38 [INFO] reload git repository ".git"
2023-12-14T19:07:39 [INFO] reload git repository ".git"
2023-12-14T19:07:39 [INFO] reload git repository ".git"
2023-12-14T19:18:07 [WARN] request completed with error: request or operation took longer than the configured timeout time
2023-12-14T19:18:07 [ERROR] request or operation took longer than the configured timeout time

Caused by:

[28] Timeout was reached

2023-12-14T20:25:28 [WARN] request completed with error: request or operation took longer than the configured timeout time

2023-12-14T20:25:28 [ERROR] request or operation took longer than the configured timeout time


Caused by:

[28] Timeout was reached

2023-12-14T20:55:13 [WARN] request completed with error: request or operation took longer than the configured timeout time

2023-12-14T20:55:13 [ERROR] request or operation took longer than the configured timeout time


Caused by:

[28] Timeout was reached

2023-12-14T20:57:56 [INFO] reload git repository ".git"

2023-12-14T20:57:56 [INFO] reload git repository ".git"

2023-12-14T20:57:58 [INFO] reload git repository ".git"

2023-12-14T20:57:58 [INFO] reload git repository ".git"

2023-12-14T20:58:01 [INFO] reload git repository ".git"

2023-12-14T20:58:04 [INFO] reload git repository ".git"

2023-12-14T20:58:04 [INFO] reload git repository ".git"

2023-12-14T20:58:04 [INFO] reload git repository ".git"

2023-12-14T20:58:04 [INFO] reload git repository ".git"

2023-12-14T20:58:05 [INFO] reload git repository ".git"

2023-12-14T20:58:05 [INFO] reload git repository ".git"

2023-12-14T20:58:05 [INFO] reload git repository ".git"

2023-12-14T20:58:05 [INFO] reload git repository ".git"

2023-12-14T20:58:05 [INFO] reload git repository ".git"

2023-12-14T20:58:05 [INFO] reload git repository ".git"

2023-12-14T20:58:06 [INFO] reload git repository ".git"

2023-12-14T20:58:06 [INFO] reload git repository ".git"

2023-12-14T20:58:06 [INFO] reload git repository ".git"

2023-12-14T20:58:06 [INFO] reload git repository ".git"

2023-12-14T20:58:06 [INFO] reload git repository ".git"

2023-12-14T20:58:06 [INFO] reload git repository ".git"

2023-12-14T20:58:06 [INFO] reload git repository ".git"

2023-12-14T20:58:06 [INFO] reload git repository ".git"

2023-12-14T20:58:06 [INFO] reload git repository ".git"

2023-12-14T20:58:06 [INFO] reload git repository ".git"

2023-12-14T20:58:07 [INFO] reload git repository ".git"

2023-12-14T20:58:07 [INFO] reload git repository ".git"

2023-12-14T20:58:07 [INFO] reload git repository ".git"

2023-12-14T20:58:07 [INFO] reload git repository ".git"

2023-12-14T20:58:07 [INFO] reload git repository ".git"

2023-12-14T20:58:07 [INFO] reload git repository ".git"

2023-12-14T20:58:07 [INFO] reload git repository ".git"

2023-12-14T20:58:07 [INFO] reload git repository ".git"

2023-12-14T20:58:07 [INFO] reload git repository ".git"

2023-12-14T20:58:08 [INFO] reload git repository ".git"

2023-12-14T20:58:08 [INFO] reload git repository ".git"

2023-12-14T20:58:08 [INFO] reload git repository ".git"

2023-12-14T20:58:08 [INFO] reload git repository ".git"

2023-12-14T20:58:08 [INFO] reload git repository ".git"

2023-12-14T20:58:08 [INFO] reload git repository ".git"

2023-12-14T20:58:08 [INFO] reload git repository ".git"

2023-12-14T20:58:08 [INFO] reload git repository ".git"

2023-12-14T20:58:08 [INFO] reload git repository ".git"

2023-12-14T20:58:09 [INFO] reload git repository ".git"

2023-12-14T20:58:09 [INFO] reload git repository ".git"

2023-12-14T20:58:09 [INFO] reload git repository ".git"

2023-12-14T20:58:09 [INFO] reload git repository ".git"

2023-12-14T20:58:09 [INFO] reload git repository ".git"

2023-12-14T20:58:09 [INFO] reload git repository ".git"

2023-12-14T20:58:09 [INFO] reload git repository ".git"

2023-12-14T20:58:10 [INFO] reload git repository ".git"

2023-12-14T20:58:10 [INFO] reload git repository ".git"

2023-12-14T20:58:10 [INFO] reload git repository ".git"

2023-12-14T20:58:10 [INFO] reload git repository ".git"

2023-12-14T20:58:10 [INFO] reload git repository ".git"

2023-12-14T20:58:10 [INFO] reload git repository ".git"

2023-12-14T20:58:10 [INFO] reload git repository ".git"

2023-12-14T20:58:10 [INFO] reload git repository ".git"

2023-12-14T20:58:10 [INFO] reload git repository ".git"

2023-12-14T20:58:11 [INFO] reload git repository ".git"

2023-12-14T20:58:11 [INFO] reload git repository ".git"

@kellyfelkins kellyfelkins added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Dec 20, 2023
@kellyfelkins
Copy link
Author

If the file is open it displays in the dialog properly.

Screen Shot 2023-12-20 at 10 51 38 AM

@JosephTLyons JosephTLyons added file finder Feedback for file management, navigation, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Dec 20, 2023
@SomeoneToIgnore SomeoneToIgnore mentioned this issue Dec 21, 2023
Merged
SomeoneToIgnore referenced this issue Dec 21, 2023
@SomeoneToIgnore
For file finder queries, match in all gitignored worktree entries (#3748
87a1387 
)

Deals with https://github.com/zed-industries/community/issues/2347
Part of https://github.com/zed-industries/community/issues/1538

Now file finder will match all gitignored worktree entries.
Zed does not traverse gitignored dirs by default, which means that not
all gitignored files will be matches, but all that were toggled in
project panel and all root non-directory gitignored entries will be now
used, hopefully causing less questions.

Release Notes:

- Improved file finder to match all gitignored files that were added
into worktrees (e.g. due to opening gitignored directories in project
panel)
@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@notpeter
Copy link
Member

Hi @kellyfelkins Can you confirm you are still seeing this issue?

I was able to reproduce your issue (certain dot files not suggested) but only if those files were matched by .gitignore rules. Does this match your configuration?

@notpeter
Copy link
Member

Closing as duplicate of:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug [core label] file finder Feedback for file management, navigation, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kellyfelkins @notpeter @JosephTLyons