Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtsls not automatically updated to latest version #18349

Open
1 task done
niklaswimmer opened this issue Sep 25, 2024 · 0 comments
Open
1 task done

vtsls not automatically updated to latest version #18349

niklaswimmer opened this issue Sep 25, 2024 · 0 comments
Labels
defect [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc typescript TypeScript programming language support

Comments

@niklaswimmer
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I noticed that the vtsls used in Zed is not up to date. Right now the latest version is 0.2.6, but when I look at languages/vtsls/node_modules/.package-lock.json it says that it is using vtsls 0.2.5. I looked at the implementation of the vtsls language adapter and am pretty sure the issue is that the function for retrieving the new package versions only does so, if the typescript version is out of date - ignoring the current vtsls version.

let should_install_language_server = self
.node
.should_install_npm_package(
package_name,
&server_path,
&container_dir,
latest_version.typescript_version.as_str(),
)
.await;
if should_install_language_server {
self.node
.npm_install_packages(
&container_dir,
&[
(package_name, latest_version.typescript_version.as_str()),
(
"@vtsls/language-server",
latest_version.server_version.as_str(),
),
],
)
.await?;
}

What probably happened is that typescript got an update, the new version was downloaded (backed by my package-lock.json that shows me that I have the latest TS version - 5.6.2), then at some point vtsls released an update that updated the TS version it depends on, but because the TS version is still the same no new fetch happened.

I personally solved this in the most straight forward way possible: closing Zed, yeeting the vtsls folder and opening Zed again. This causes a refetch.

Anyways, the fix should be rather simple, I am leaving this as issue, because I do not think I will have the time to actually make the change any time soon, but maybe someone else can!

Environment

Zed: v0.155.0 (Zed Dev 90a12f5)
OS: Windows 10.0.19045
Memory: 31.3 GiB
Architecture: x86_64
GPU: AMD Radeon(TM) 760M || AMD proprietary driver || 23.40.18.02 (LLPC)

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

No response

@niklaswimmer niklaswimmer added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Sep 25, 2024
@notpeter notpeter added typescript TypeScript programming language support extension infrastructure Feedback for extensions APIs, creation, management, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc typescript TypeScript programming language support
Projects
None yet
Development

No branches or pull requests

2 participants