Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable keyring prompting #17460

Open
1 task done
mil-ad opened this issue Sep 5, 2024 · 4 comments
Open
1 task done

Disable keyring prompting #17460

mil-ad opened this issue Sep 5, 2024 · 4 comments
Labels
enhancement [core label] linux security & privacy Data privacy issue, security vulnerabilities, etc

Comments

@mil-ad
Copy link

mil-ad commented Sep 5, 2024

Check for existing issues

  • Completed

Describe the feature

When I open zeditor (on Arch linux) it prompts me to authenticate my system keyring. I don't want to give keyring access to my editor and pressing Escape gets rid of the password prompt. Is there a way to stop zeditor from requesting keyring access?

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@mil-ad mil-ad added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Sep 5, 2024
@notpeter
Copy link
Member

notpeter commented Sep 6, 2024

I believe we use the keyring for storing the following items:

  • Zed.dev session (Logging into Zed for Collab and Zed AI)
  • Assistant panel API Tokens (OpenAI, Anthropic, Gemini, etc)

On MacOS, if you logout from Zed and remove and click Reset key for any configured providers in the Assistant you should no longer receive prompts to access your Keychain.

On Linux, things are a little different (see: read_credentials and write_credentials in linux/platform.rs). It's not immediately clear to me the behavior if you don't have any stored credentials in your Keyring (logged out; assistant unconfigured; previously saved items deleted) whether you will be prompted, but ideally you would not.

@notpeter notpeter added linux security & privacy Data privacy issue, security vulnerabilities, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Sep 6, 2024
@constantitus
Copy link

It's not immediately clear to me the behavior if you don't have any stored credentials in your Keyring (logged out; assistant unconfigured; previously saved items deleted) whether you will be prompted, but ideally you would not.

I did get prompted the first time I opened the editor. Nothing has to be configured for you to get prompted.

@musjj
Copy link

musjj commented Oct 2, 2024

I deleted ~/.config/zed and ~/.cache/zed and the issue still persists (0.154.1). Not sure what's triggering it. I looked over my gpg --list-keys and I'm only seeing my personal key and proton vpn key.

@notpeter
Copy link
Member

notpeter commented Oct 4, 2024

@musjj Wrong keyring. This isn't in your GPG Keyring, it's in your XDG secrets provider (likely gnome-keyring or kwallet).

More in the docs: Zed isn't remembering my login

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] linux security & privacy Data privacy issue, security vulnerabilities, etc
Projects
None yet
Development

No branches or pull requests

4 participants